Claude: changes for issue #79 #81

Merged
Grandiras merged 1 commit from claude/issue-79 into main 2026-08-14 13:43:12 +00:00
Collaborator

Closes #79.

Closes #79.
Fold Ponente.Common into Ponente.Kanban
All checks were successful
CI / build (pull_request) Successful in 36s
0b4e82b67a
The Common project held two files — IDataEncryptor and its AES-256-GCM
implementation — and exactly one consumer. A project earns its place by
being referenced by more than one thing, and this one never was, so it
was a csproj, a solution entry, two Dockerfile COPY layers and a
published assembly bought with nothing.

The code moves to src/Ponente.Kanban/Encryption/ under the namespace
Ponente.Kanban.Encryption, beside Auth/ and Data/ rather than inside
either — encryption at rest is not the data layer's private business,
Program.cs registers it too. Extracting a library again is cheap the day
a second consumer exists; predicting one is not.

The .Kanban suffix stays. Common was shared library code and never a
sibling product, so removing it says nothing about whether siblings
arrive later — what would foreclose them is handing the umbrella name to
one product. It also reaches further into the deployment than it looks
(ENTRYPOINT, Dockerfile paths, KanbanDbContext, the
ConnectionStrings__KanbanDb variable both stacks set), and no member ever
sees it: the UI, the manifest and the domain all say Ponente already.

Verified: dotnet build -c Release clean, 165/165 unit tests pass, and the
Dockerfile's publish command produces Ponente.Kanban.dll with no
Ponente.Common.dll beside it.
Author
Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/215); the reply will link the full session transcript. 📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-81/run-215.md) — updating every ~5 minutes while the task runs.
claude-reviewer left a comment

Verdict: approve — no blocking issues found.

Clean, mechanical fold of Ponente.Common into Ponente.Kanban (namespace Ponente.Kanban.Encryption). All the pieces move together consistently: .csproj/.sln/Dockerfile drop the second project, the three using sites (Program.cs, DatabaseInitializer.cs, EncryptionMigrator.cs, KanbanDbContext.cs) are updated, and both prose references in CLAUDE.md and README.md (the two-projects blurb and the "Encryption at rest" section, including dropping the stale "both apps" wording) are updated to match. Verified against the current tree that no other file (tests, deploy, docs) still references Ponente.Common or the old namespace. The added CLAUDE.md rationale for keeping the .Kanban suffix despite the merge is consistent with the rest of the doc's style and gives a clear reason not to rename later opportunistically. Nothing to flag.


⏱ 0m 50s · 19 turns · tokens: 57.4k in / 2.9k out (+1448.4k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Clean, mechanical fold of `Ponente.Common` into `Ponente.Kanban` (namespace `Ponente.Kanban.Encryption`). All the pieces move together consistently: `.csproj`/`.sln`/`Dockerfile` drop the second project, the three `using` sites (`Program.cs`, `DatabaseInitializer.cs`, `EncryptionMigrator.cs`, `KanbanDbContext.cs`) are updated, and both prose references in `CLAUDE.md` and `README.md` (the two-projects blurb and the "Encryption at rest" section, including dropping the stale "both apps" wording) are updated to match. Verified against the current tree that no other file (tests, deploy, docs) still references `Ponente.Common` or the old namespace. The added `CLAUDE.md` rationale for keeping the `.Kanban` suffix despite the merge is consistent with the rest of the doc's style and gives a clear reason not to rename later opportunistically. Nothing to flag. --- ⏱ 0m 50s · 19 turns · tokens: 57.4k in / 2.9k out (+1448.4k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-81/run-215.md) <!-- claude-verdict:approve --> <!-- claude-reviewed-head:0b4e82b67a22129bf947ed76b00b726829909336 -->
Grandiras deleted branch claude/issue-79 2026-08-14 13:43:12 +00:00
Grandiras referenced this pull request from a commit 2026-08-14 13:43:12 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Grandiras/Ponente!81
No description provided.