Fold Ponente.Common into Ponente.Kanban #79
Labels
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/Ponente#79
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Common project is kinda pointless, fold it in. Also decide, whether the Kanban name suffix should remain or if the remaining project should just be called Ponente.
🤖 On it — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
Folded
Ponente.CommonintoPonente.Kanbanand answered the naming question. Branch:claude/issue-79.The fold
Ponente.Commonheld two files —IDataEncryptorandAesGcmDataEncryptor— and exactly one consumer. A project earns its place by being referenced by more than one thing, and this one never was, so it was a csproj, a solution entry, two DockerfileCOPYlayers and a separately published assembly bought with nothing.The code moves to
src/Ponente.Kanban/Encryption/underPonente.Kanban.Encryption, as a folder besideAuth/andData/rather than inside either — encryption at rest isn't the data layer's private business,Program.csregisters it too. Fourusinglines change; nothing else in the source did. Also removed: theProjectReference, the solution's project + config + nesting entries, and the two Common lines in the Dockerfile. README's project-layout block and the two stale CLAUDE.md passages (Ponente.Common.Encryption, "both apps") are updated.The name:
.KanbanstaysThree reasons, recorded in CLAUDE.md so it isn't re-litigated:
Ponente.Notesbeside a plainPonentereads as a child of it rather than a peer.ENTRYPOINT, the Dockerfile paths, the release skill,KanbanDbContext, and theConnectionStrings__KanbanDbvariable both stacks set. Renaming is 99 files of churn plus an env change on two servers.Ponente.Kanbanis an assembly name and a namespace root.I made this call rather than asking, since the issue said to decide — but it's a one-line revert of the docs paragraph if you'd rather have the rename, and I'd do it as its own PR either way, not folded into this one.
Verified
dotnet build Ponente.sln -c Release— succeeds from a clean tree, 0 errors (the oneCS8604warning inCalendar.razorpredates this and is untouched).dotnet test Ponente.sln -c Release— 165/165 pass.dotnet publish … -o … /p:UseAppHost=false) producesPonente.Kanban.dllwith noPonente.Common.dllbeside it, so the unchangedENTRYPOINTstill resolves.Not run: the Playwright e2e suite and an actual image build — this runner has no container engine (the same limitation
ci.ymldocuments). Nothing here touches runtime behaviour, markup or CSS, so there's no e2e surface to move; the image build is covered insofar as the publish step it wraps was run directly.⏱ 3m 51s · 30 turns · tokens: 73.6k in / 12.6k out (+2265.2k cache-read)
📜 Full session transcript
→ Opened PR: #81