Claude: changes for issue #130 #137

Merged

Grandiras merged 1 commit from claude/issue-130 into main

2026-08-21 02:18:52 +00:00

claude-bot commented

2026-08-21 02:17:56 +00:00

Collaborator

Closes #130.

claude-bot added 1 commit

2026-08-21 02:17:56 +00:00

Delete unused MemberService.UpdateDisplayNameAsync/UpdateAvatarAsync

CI / build (pull_request) Successful in 36s

Details

e7aa51dc1c

Neither had a caller in src/ or tests/ — every profile write goes through
RefreshProfileAsync or SetProfileAsync. They were also the only member
writers that changed a name or a picture without firing
BoardNotifier.NotifyProfileChanged, so a future caller reaching for one
would have left open nav headers showing the old face until a reload.

Records that invariant in docs/auth.md so the next writer added here
fires the profile event too.

Closes #130

claude-bot referenced this pull request

2026-08-21 02:17:57 +00:00

MemberService.UpdateDisplayNameAsync and UpdateAvatarAsync have no callers #130

claude-bot commented

2026-08-21 02:18:00 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/360); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-137/run-360.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-21 02:18:25 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Clean deletion of two unused MemberService methods (UpdateDisplayNameAsync, UpdateAvatarAsync) — verified via grep that neither has any callers anywhere in the codebase (Razor components or C#). Both only fired NotifyAllBoardsChanged rather than the profile-specific NotifyProfileChanged, so removing them rather than fixing them is the right call per the file's own documented convention.

The docs/auth.md update in the same PR explains why these existed and why they were removed instead of fixed, and adds forward guidance ("if you need a third one, make it fire that too") — exactly the kind of load-bearing context this repo's docs are meant to carry, per CLAUDE.md's requirement to update docs in the same PR as the change that outdates them.

No functional risk: removing dead code with no call sites.

⏱ 0m 13s · 4 turns · tokens: 17.7k in / 859 out (+148.9k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Clean deletion of two unused `MemberService` methods (`UpdateDisplayNameAsync`, `UpdateAvatarAsync`) — verified via grep that neither has any callers anywhere in the codebase (Razor components or C#). Both only fired `NotifyAllBoardsChanged` rather than the profile-specific `NotifyProfileChanged`, so removing them rather than fixing them is the right call per the file's own documented convention. The `docs/auth.md` update in the same PR explains why these existed and why they were removed instead of fixed, and adds forward guidance ("if you need a third one, make it fire that too") — exactly the kind of load-bearing context this repo's docs are meant to carry, per CLAUDE.md's requirement to update docs in the same PR as the change that outdates them. No functional risk: removing dead code with no call sites. --- ⏱ 0m 13s · 4 turns · tokens: 17.7k in / 859 out (+148.9k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-137/run-360.md)