MemberService.UpdateDisplayNameAsync and UpdateAvatarAsync have no callers #130
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/Ponente#130
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
src/Ponente.Kanban/Services/MemberService.csstill exposesUpdateDisplayNameAsync(line 58) andUpdateAvatarAsync(line 70). Nothing insrc/ortests/calls either — every caller goes throughRefreshProfileAsyncor, since #115,SetProfileAsync.They are also the two that write half a profile without firing
BoardNotifier.NotifyProfileChanged, so a future caller reaching for one would silently leave the nav header showing the old face. Noticed while renaming their sibling; deleting them is the whole fix.Filed by Claude while working on #115 (run).
🤖 On it — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
🤖 On it — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
Deleted both methods on branch
claude/issue-130.What I checked first. A repo-wide grep for
UpdateDisplayNameAsyncandUpdateAvatarAsync(excluding.git/) returned exactly two hits: the two definitions themselves. No callers insrc/, none intests/, no mentions indocs/. The issue's read was correct, so the deletion is the whole change — 24 lines out ofServices/MemberService.cs, nothing else moved.One documentation line added.
docs/auth.mdalready had a bullet sayingMemberService"has two ways to write a member's name and picture" — which was aspirational while these two existed and is now literally true. I extended that bullet to record why the list is short: both survivors fireBoardNotifier.NotifyProfileChanged, these two fired only the board event, and a third writer that skips it leaves every open nav header showing the old face until a reload. That's the trap the issue spotted, and it's worth a sentence where the next person adding a profile writer will read it rather than being lost with the code.No
Changelog.Unreleasedentry: nothing a member sees changes — dead code in, dead code out.Verified.
dotnet build Ponente.slnsucceeds with 0 warnings / 0 errors, anddotnet test Ponente.slnpasses 380/380. That includesDocumentationTests, which is the check that thedocs/edit doesn't break the coverage rules inCLAUDE.md. No e2e run — nothing user-visible is touched, and the deleted methods had no reachable path from the UI to exercise.No follow-up issues filed; nothing turned up outside the task.
⏱ 1m 6s · 11 turns · tokens: 21.9k in / 3.3k out (+322.8k cache-read)
📜 Full session transcript
→ Opened PR: #137