Claude: changes for issue #135 #136

Merged

Grandiras merged 1 commit from claude/issue-135 into main

2026-08-21 01:57:20 +00:00

claude-bot commented

2026-08-21 01:56:07 +00:00

Collaborator

Closes #135.

claude-bot added 1 commit

2026-08-21 01:56:07 +00:00

deploy: correct the header's claim that production copies nothing to the server

CI / build (pull_request) Successful in 37s

Details

5f86e5b6ee

Both stacks set SERVER_STATE_DIR now, so production does keep a 0600 copy
of its env file in the podman user's home — the property the
release-without-a-workstation change traded away on purpose. The script's
header still described the old world, which is the worst place to be wrong
about where secrets live. Rewritten to match deploy/README.md and
docs/deployment.md, and the same stale sentence fixed in .env.dev.example.

claude-bot referenced this pull request

2026-08-21 01:56:08 +00:00

deploy.sh's header still says production copies nothing to the server #135

claude-bot commented

2026-08-21 01:56:10 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/357); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-136/run-357.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-21 01:56:56 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Comment-only fix in deploy/deploy.sh and deploy/.env.dev.example. The old comments claimed production leaves SERVER_STATE_DIR unset and copies nothing to the server; that had gone stale — deploy/.env.example already sets SERVER_STATE_DIR=/home/podman/ponente for production, and docs/deployment.md already documents this as a deliberate reversal (needed so a release can happen without a workstation). The new comment text matches the actual current configuration and the reasoning already recorded in docs/deployment.md and deploy/backups.md. No functional/code changes, low risk, brings the header comments back in sync with reality.

⏱ 0m 31s · 9 turns · tokens: 23.5k in / 2.2k out (+341.2k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Comment-only fix in `deploy/deploy.sh` and `deploy/.env.dev.example`. The old comments claimed production leaves `SERVER_STATE_DIR` unset and copies nothing to the server; that had gone stale — `deploy/.env.example` already sets `SERVER_STATE_DIR=/home/podman/ponente` for production, and `docs/deployment.md` already documents this as a deliberate reversal (needed so a release can happen without a workstation). The new comment text matches the actual current configuration and the reasoning already recorded in `docs/deployment.md` and `deploy/backups.md`. No functional/code changes, low risk, brings the header comments back in sync with reality. --- ⏱ 0m 31s · 9 turns · tokens: 23.5k in / 2.2k out (+341.2k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-136/run-357.md)