deploy.sh's header still says production copies nothing to the server #135
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/Ponente#135
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The comment block at the top of
deploy/deploy.shsays:Both halves are now false.
deploy/.env.examplesetsSERVER_STATE_DIR=/home/podman/ponente, anddeploy/README.mdsays so outright — "Both stacks now setSERVER_STATE_DIR, and that is a real trade" — because the workstation-free release needs something on the server able to recreate the containers unattended. Production therefore does keep a0600copy of its env file in the podman user's home.This is the load-bearing kind of stale: somebody reading only the script would conclude production's secrets are never written to disk on the server, which is exactly the property the release-without-a-workstation change traded away on purpose. The reasoning is already written down correctly in
deploy/README.mdanddocs/deployment.md; only the script's header disagrees.Found while adding the backup timer (#132) — the same
SERVER_STATE_DIRblock is what installs it — and left alone there to keep that change to one subject.Filed by Claude while working on #132 (run).
🤖 On it — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
Pushed
claude/issue-135.What changed — comments only, no behaviour.
deploy/deploy.shheader: the two paragraphs claiming production copies nothing to the server and that the dev stack is the loneSERVER_STATE_DIRexception are replaced. The new text keeps the part that is still true (the deploy itself needs nothing on the far side — podman-compose runs on the workstation against the server's socket), then states plainly that both stacks setSERVER_STATE_DIR, that production's secrets therefore also sit in a0600file in the podman user's home, and why that reversal was made on purpose: a release without a workstation needs something on the server able to recreate the containers unattended, and that thing needs the values. It also notes the same copy is what lets the stack back itself up (#132's timer), says what unsetting it costs, and points atdeploy/README.mdfor the longer version. The "re-copied on every deploy so the server's copy cannot fall behind the repo" reasoning is kept — it applies to every stack now, not just dev.One thing beyond the issue's scope, fixed rather than filed:
deploy/.env.dev.examplecarried the identical false claim in itsSERVER_STATE_DIRcomment — "Production leaves it unset, and then nothing is copied at all." Same sentence, same subject, one line; splitting it into its own issue would have left the wrong statement sitting next to the corrected one. It now says production sets it too and points at.env.example, which holds the full trade.Verified:
bash -n deploy/deploy.shpasses;./deploy/deploy.sh --helpstill prints the intended block (itseds lines 2–11, above the edited region, and that output is unchanged);dotnet test Ponente.sln— 380 passed, 0 failed, includingDocumentationTests.No changelog entry: nothing here is visible to a member. No docs page needed updating —
deploy/README.mdanddocs/deployment.mdwere already the correct versions this change copies from.⏱ 1m 23s · 12 turns · tokens: 29.6k in / 4.5k out (+328.2k cache-read)
📜 Full session transcript
→ Opened PR: #136