Claude: changes for issue #80 #81

Merged
Grandiras merged 1 commit from claude/issue-80 into main 2026-07-29 17:33:48 +00:00
Collaborator

Closes #80.

Closes #80.
feat: default LoginForm copy to "username" instead of "handle"
All checks were successful
CI / pds-integration (pull_request) Successful in 25s
CI / build-and-test (pull_request) Successful in 54s
Sync Closures to GitHub / sync-closure (pull_request) Successful in 7s
7dbb26e65a
The LoginForm field label now defaults to "Username" and the hint to
"Your Atmosphere account username — your PDS is detected automatically."

Same split as #32: the community's word in the copy a person reads, the
protocol's word in the code. Everything below the copy is untouched —
HandleLabel/HandlePlaceholder/HandleHint, the `handle` query parameter,
the `atproto-handle` input id, and the developer-facing /atproto/login
error text are all unchanged, so nothing here breaks source or binary
compatibility.

closes #80
Author
Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/165); the reply will link the full session transcript. 📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-81/run-165.md) — updating every ~5 minutes while the task runs.
claude-reviewer left a comment

Verdict: approve — no blocking issues found.

Clean, well-scoped change: renames the default HandleLabel/HandleHint copy from "Handle" to "Username" while leaving the underlying parameter names, query parameter, input id, and error text untouched. The .razor source, XML doc comments, docs/blazor.md table/prose, and CHANGELOG.md entry are all updated consistently. Checked for other references to the old default strings (tests, resx/translation resources) and found none, so nothing was missed. No functional or breaking-change concerns.


⏱ 0m 18s · 5 turns · tokens: 17.1k in / 1.0k out (+182.9k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Clean, well-scoped change: renames the default `HandleLabel`/`HandleHint` copy from "Handle" to "Username" while leaving the underlying parameter names, query parameter, input id, and error text untouched. The `.razor` source, XML doc comments, `docs/blazor.md` table/prose, and `CHANGELOG.md` entry are all updated consistently. Checked for other references to the old default strings (tests, resx/translation resources) and found none, so nothing was missed. No functional or breaking-change concerns. --- ⏱ 0m 18s · 5 turns · tokens: 17.1k in / 1.0k out (+182.9k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-81/run-165.md) <!-- claude-verdict:approve --> <!-- claude-reviewed-head:7dbb26e65ae332f501ad5dc622d2530aaf2d8b67 -->
Grandiras deleted branch claude/issue-80 2026-07-29 17:33:48 +00:00
Grandiras referenced this pull request from a commit 2026-07-29 17:33:50 +00:00
Sign in to join this conversation.
No description provided.