Adopt 'Atmosphere account' terminology in default OAuth/login copy #32
Labels
No labels
breaking-change
bug
documentation
duplicate
enhancement
good first issue
help wanted
performance
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/ATProto.NET#32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The community has been converging on "Atmosphere" as the user-facing umbrella term for the AT Protocol ecosystem (analogous to how "the Web" is the user-facing term while "HTTP" stays under the hood). Several apps have already started shipping copy like "Sign in with your Atmosphere account" instead of "Sign in with AT Protocol", and it reads noticeably more humanly to non-technical users.
It would be great if
ATProtoNet.Blazor'sLoginForm(and any default copy in the OAuth start endpoints) supported this terminology — either as configurable strings, or as the new default with the old "AT Protocol" copy still available for opt-in.Why this matters
Concretely, what I'd like
The default copy in components like
LoginFormis currently something like:I'd like to be able to ship it as either:
…or similar. Two reasonable shapes for the API:
HeadingText,SubtitleText, etc. parameters toLoginFormso apps can fully override the strings without re-implementing the form.Either works for me — option 1 alone is enough to unblock downstream apps; option 2 would be the kinder default for everyone.
Context
I'm hitting this on a small Blazor app that uses
ATProtoNet.Blazor. Right now I'm overriding the heading/subtitle in my own page wrapper and only usingLoginFormfor the form fields — would prefer to just configure copy on the component itself.Happy to send a PR if you'd like, just want to make sure the direction is welcome before I start.
Also, supporting translations would be nice.
Implemented in v0.4.0 (commit
4f18c36).LoginFormnow defaults to the "Atmosphere account" terminology:HeadingText/SubtitleTextparameters for optional heading + subtitle above the form (no default, rendered only when set)string?and consult an injectedIStringLocalizer<LoginForm>when one is registered, falling back to the English defaults — translations work via standard ASP.NET Core localization (.resx, JSON, custom factories, etc.)Both samples (
BlazorOAuthSample,ServerIntegrationSample) anddocs/blazor.mdupdated to reflect the new copy and document the translation flow.