Claude: changes for issue #125 #139

Merged

Grandiras merged 1 commit from claude/issue-125 into main

2026-08-21 02:26:29 +00:00

claude-bot commented

2026-08-21 02:25:20 +00:00

Collaborator

Closes #125.

claude-bot added 1 commit

2026-08-21 02:25:20 +00:00

Make the phone suite build its own fixtures

CI / build (pull_request) Successful in 39s

Details

866d2fc2bc

mobile.spec.js's card-dialog test opened by waiting for a card wearing a
tag, and nothing in the file made either — so on a stack brought up with
`down -v` (or any stack the teardown has since reclaimed) it spent ten
seconds on waitForSelector and failed before measuring the two chips it
exists for. It now mints its own tag through /admin/tags and its own
card wearing it, the way filter.spec.js does, and measures those rather
than whatever the board happened to hold.

The touch-drag test had the same dependency in a quieter form: it needed
the first column to overflow and skipped when it didn't, so on an empty
board the one test that drives the interop's scroll never ran. It now
fills the column until it scrolls — nothing minted on a board that is
already full enough — and fails loudly if it can't.

docs/testing.md gains the rule: a spec has to pass against a stack with
nothing on it, because a recreated stack is exactly that.

Fixes #125

claude-bot referenced this pull request

2026-08-21 02:25:21 +00:00

mobile.spec.js's card-dialog test needs a tagged card it never creates #125

claude-bot commented

2026-08-21 02:25:23 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/363); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-139/run-363.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-21 02:26:21 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

This PR fixes the mobile e2e tests to build their own fixtures instead of relying on whatever the board happens to already hold, consistent with the fixture-isolation rule the docs/testing.md addition documents. I verified the changes against the actual source:

addCard's new .composer-title selector and the tagName picker flow match CardModal.razor (the composer input.composer-title is rendered when CanEdit, and TagPicker is available even when IsNew).
createTag's .admin-form / .admin-table selectors match Admin/Tags.razor.
The tag-chip-size test's .card .tag-chip-static and .tag-picker .tag-chip selectors match CardView.razor / TagPicker.razor.
The touch-drag test's fill-until-overflow loop is capped (8 filler cards, target 60px) and the final assertion gives a clear failure message if a stack somehow can't reach it, rather than silently skipping — which is exactly the bug (test.skip on an empty board silently never running) the diff calls out in its own comments.
The new docs/testing.md paragraph accurately describes the rule the code now follows.

No correctness issues found. Good to merge.

⏱ 0m 48s · 18 turns · tokens: 28.6k in / 3.1k out (+837.2k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. This PR fixes the mobile e2e tests to build their own fixtures instead of relying on whatever the board happens to already hold, consistent with the fixture-isolation rule the docs/testing.md addition documents. I verified the changes against the actual source: - `addCard`'s new `.composer-title` selector and the `tagName` picker flow match `CardModal.razor` (the composer `input.composer-title` is rendered when `CanEdit`, and `TagPicker` is available even when `IsNew`). - `createTag`'s `.admin-form` / `.admin-table` selectors match `Admin/Tags.razor`. - The tag-chip-size test's `.card .tag-chip-static` and `.tag-picker .tag-chip` selectors match `CardView.razor` / `TagPicker.razor`. - The touch-drag test's fill-until-overflow loop is capped (8 filler cards, target 60px) and the final assertion gives a clear failure message if a stack somehow can't reach it, rather than silently skipping — which is exactly the bug (`test.skip` on an empty board silently never running) the diff calls out in its own comments. - The new `docs/testing.md` paragraph accurately describes the rule the code now follows. No correctness issues found. Good to merge. --- ⏱ 0m 48s · 18 turns · tokens: 28.6k in / 3.1k out (+837.2k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-139/run-363.md)