Claude: changes for issue #120 #133

Merged

Grandiras merged 1 commit from claude/issue-120 into main

2026-08-21 01:22:11 +00:00

claude-bot commented

2026-08-20 22:02:55 +00:00

Collaborator

Closes #120.

claude-bot added 1 commit

2026-08-20 22:02:55 +00:00

Pin the calendar day cell's absent click handler with null!

CI / build (pull_request) Successful in 32s

Details

9308a8337e

The build's one warning, CS8604 on
`@onclick="@(cards.Count > 0 ? () => OpenDay(day) : null)"`, was an
unexpressed intent rather than a bug: an empty day cell deliberately gets
no handler. The forgiving operator says so and emits no code, so the
rendered output is byte-for-byte what it was.

Not EventCallback<MouseEventArgs>.Empty, the other candidate: Empty
carries a no-op delegate, so HasDelegate is true, AddAttribute writes the
attribute and a listener is registered — every click on a dateless cell
would buy a server round trip to run nothing. Recorded in the comment and
in docs/calendar.md so the tidier-looking spelling is not tried again.

claude-bot referenced this pull request

2026-08-20 22:02:56 +00:00

The build's one warning: CS8604 on the calendar day cell's conditional @onclick #120

claude-bot commented

2026-08-21 00:59:18 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/346); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-133/run-346.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-21 01:21:10 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Small, correct fix: replaces the bare null in the @onclick conditional with null! to suppress a CS8604 nullable warning, with no behavioral change — the branch still assigns a null delegate so HasDelegate stays false and no attribute/listener is written. The accompanying comment (mirrored in both Calendar.razor and docs/calendar.md) correctly explains why EventCallback<MouseEventArgs>.Empty would be the wrong choice here: Empty wraps a real no-op Action delegate, so HasDelegate would be true and every click on an empty calendar cell would trigger an unnecessary server round trip. I verified this against the actual ASP.NET Core EventCallback source — Empty is indeed constructed with a non-null no-op delegate, confirming the claim. Documentation and code stay in sync as required by this repo's conventions. No issues found.

⏱ 21m 34s · 7 turns · tokens: 23.7k in / 4.1k out (+296.2k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Small, correct fix: replaces the bare `null` in the `@onclick` conditional with `null!` to suppress a CS8604 nullable warning, with no behavioral change — the branch still assigns a null delegate so `HasDelegate` stays false and no attribute/listener is written. The accompanying comment (mirrored in both `Calendar.razor` and `docs/calendar.md`) correctly explains why `EventCallback<MouseEventArgs>.Empty` would be the wrong choice here: `Empty` wraps a real no-op `Action` delegate, so `HasDelegate` would be true and every click on an empty calendar cell would trigger an unnecessary server round trip. I verified this against the actual ASP.NET Core `EventCallback` source — `Empty` is indeed constructed with a non-null no-op delegate, confirming the claim. Documentation and code stay in sync as required by this repo's conventions. No issues found. --- ⏱ 21m 34s · 7 turns · tokens: 23.7k in / 4.1k out (+296.2k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-133/run-346.md)