Claude: changes for issue #113 #126

Merged

Grandiras merged 1 commit from claude/issue-113 into main

2026-08-19 17:59:03 +00:00

claude-bot commented

2026-08-19 17:57:47 +00:00

Collaborator

Closes #113.

claude-bot added 1 commit

2026-08-19 17:57:47 +00:00

Clicking the app title opens the board you are on

CI / build (pull_request) Successful in 34s

Details

ac071c3197

The wordmark in the header linked to a bare `/`, which means *the default
board* — so from a second board's calendar, its tags, or the board itself,
the way back to the cards quietly moved you to the first board in the list
and forgot the one you had picked. It now points at the board `ActiveBoardId`
resolves (`HomeHref`), and falls back to `/` only where there is no board to
name: signed out, on the general calendar, and on the two deployment-wide
admin pages.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

claude-bot referenced this pull request

2026-08-19 17:57:48 +00:00

Clicking the app title should open the current board, not the first one #113

claude-bot commented

2026-08-19 17:57:50 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/307); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-126/run-307.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-19 17:58:36 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Small, well-scoped fix. HomeHref reuses the existing BoardHref(int?, string) overload the same way the Board/Calendar nav links already do, so the wordmark now goes to /board/{id} for the board named by the current URL and falls back to / exactly when ActiveBoardId is null (signed out, general calendar, and the two deployment-wide admin pages) — consistent with the stated intent and with AdminHref's established pattern.

The new e2e test covers the two board-scoped cases (calendar of a board, admin page scoped to a board) and the no-board fallback (/calendar/all). Changelog entries are present in both en and de. The doc page addition reads consistently with the rest of boards-and-permissions.md.

One minor, non-blocking behavioral note: clicking the wordmark while already on the bare /board (default board, no id in the URL) now resolves ActiveBoardId to _boards[0].Id and produces an explicit /board/{id} link instead of staying on the bare /. This mirrors the pre-existing Board/Calendar nav-link behavior (same BoardHref call at lines 116/245), so it's not a regression introduced by this PR, just worth noting it turns a bare-path visit into an explicit-id link on click.

⏱ 0m 37s · 6 turns · tokens: 26.1k in / 3.1k out (+209.4k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Small, well-scoped fix. `HomeHref` reuses the existing `BoardHref(int?, string)` overload the same way the Board/Calendar nav links already do, so the wordmark now goes to `/board/{id}` for the board named by the current URL and falls back to `/` exactly when `ActiveBoardId` is null (signed out, general calendar, and the two deployment-wide admin pages) — consistent with the stated intent and with `AdminHref`'s established pattern. The new e2e test covers the two board-scoped cases (calendar of a board, admin page scoped to a board) and the no-board fallback (`/calendar/all`). Changelog entries are present in both `en` and `de`. The doc page addition reads consistently with the rest of `boards-and-permissions.md`. One minor, non-blocking behavioral note: clicking the wordmark while already on the bare `/board` (default board, no id in the URL) now resolves `ActiveBoardId` to `_boards[0].Id` and produces an explicit `/board/{id}` link instead of staying on the bare `/`. This mirrors the pre-existing Board/Calendar nav-link behavior (same `BoardHref` call at lines 116/245), so it's not a regression introduced by this PR, just worth noting it turns a bare-path visit into an explicit-id link on click. --- ⏱ 0m 37s · 6 turns · tokens: 26.1k in / 3.1k out (+209.4k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-126/run-307.md)