Claude: changes for issue #101 #103

Merged

Grandiras merged 1 commit from claude/issue-101 into main

2026-08-18 08:16:00 +00:00

claude-bot commented

2026-08-18 08:10:30 +00:00

Collaborator

Closes #101.

claude-bot added 1 commit

2026-08-18 08:10:31 +00:00

Style the comment thread's two bare buttons

CI / build (pull_request) Successful in 34s

Details

3c64406961

The Cancel on a comment edit and the No on a delete confirm carried no
class at all, so each fell back to the browser's own button next to a
.btn-primary or a .btn-danger pill — a small square grey box beside a
pill, which is what issue #101 shows.

They are the shared button system's secondary case, and .btn-secondary
was already defined for it and used nowhere. Use it rather than adding
container rules for .comment-edit-actions and .comment-delete-confirm:
each button says what it looks like, once.

The e2e assertion goes into the existing comment test, which already has
a comment of its own open in the card dialog — the fixture is the whole
cost of the check. It holds that comment by data-comment-id, since a
comment being edited is a textarea and stops matching a hasText filter.

claude-bot referenced this pull request

2026-08-18 08:10:31 +00:00

Missing styles #101

claude-bot commented

2026-08-18 08:10:33 +00:00

Author

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/274); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-103/run-274.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-08-18 08:11:09 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Small, well-scoped fix: adds btn-secondary to the comment thread's two "back out" buttons (Cancel while editing, No on delete confirm), which previously rendered as unstyled bare buttons beside a .btn-primary/.btn-danger. Verified .btn-secondary is an existing shared class (app.css, sharing the button system's border-radius: var(--radius-pill) and hover/disabled states), so this is a pure class addition with no new styling risk. Changelog entries added in both en/de, consistent with the project convention of dating entries to the PR rather than the tag. The new e2e assertions correctly key off data-comment-id rather than text content (avoiding the textarea/hasText trap already documented for this suite), retry the click via toPass for circuit-readiness, and check border-radius against the --radius-pill token rather than a hardcoded pixel value. Everything checks out — no functional or correctness concerns.

⏱ 0m 22s · 6 turns · tokens: 64.7k in / 1.2k out (+376.4k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Small, well-scoped fix: adds `btn-secondary` to the comment thread's two "back out" buttons (Cancel while editing, No on delete confirm), which previously rendered as unstyled bare buttons beside a `.btn-primary`/`.btn-danger`. Verified `.btn-secondary` is an existing shared class (app.css, sharing the button system's `border-radius: var(--radius-pill)` and hover/disabled states), so this is a pure class addition with no new styling risk. Changelog entries added in both en/de, consistent with the project convention of dating entries to the PR rather than the tag. The new e2e assertions correctly key off `data-comment-id` rather than text content (avoiding the textarea/hasText trap already documented for this suite), retry the click via `toPass` for circuit-readiness, and check `border-radius` against the `--radius-pill` token rather than a hardcoded pixel value. Everything checks out — no functional or correctness concerns. --- ⏱ 0m 22s · 6 turns · tokens: 64.7k in / 1.2k out (+376.4k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/Ponente/pr-103/run-274.md)