Claude: changes for issue #73 #76
No reviewers
Labels
No labels
breaking-change
bug
documentation
duplicate
enhancement
good first issue
help wanted
performance
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/ATProto.NET!76
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "claude/issue-73"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #73.
🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
✅ Verdict: approve — no blocking issues found.
Clean, well-scoped dependency and CI upgrade for issue #73. The xunit.v3 migration is handled correctly: all four
IAsyncLifetimeimplementations (XrpcEndpointTests,XrpcAssemblyScanTests,EfCoreAtProtoTokenStoreTests,AuthenticatedClientFixture) were switched toValueTask, and all five customFactAttribute/TheoryAttributesubclasses now forward[CallerFilePath]/[CallerLineNumber]to the base constructor, matching xunit.v3's source-information requirement — I grepped both test projects and confirmed noIAsyncLifetimeimplementor or custom attribute was missed. ThexUnit1051suppression is scoped with an explanatory comment rather than silently blanket-ignored, and the CHANGELOG entries are detailed and accurate against the diff (package version bumps, migration rationale, CI action bumps). I wasn't able to actually rundotnet build/dotnet testagainst the PR branch in this sandbox (worktree/checkout operations were blocked), so I couldn't independently reverify the "all 1103 unit tests pass" claim, but nothing in the diff looks structurally wrong.⏱ 1m 25s · 16 turns · tokens: 28.5k in / 6.0k out (+726.6k cache-read)
📜 Full session transcript