Fix visual inconsistencies #141
Labels
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Grandiras/Ponente#141
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Do a general visual polishing and information displayment pass on the app. Some nudges:
🤖 On it — follow along in the action run; the reply will link the full session transcript.
📜 Live transcript — updating every ~5 minutes while the task runs.
Pushed to
claude/issue-141.What changed
Bottom sheets no longer cast a shadow on the nav bar.
--shadow-lgis symmetric, and a sheet seated on the phone's bottom bar has exactly one strip of screen below it to cast on — so its lower half landed entirely on the bar, which is what made the bar read as tucked under the sheet. Added--shadow-sheet, the one asymmetric shadow in the file: same weight, noybelow zero, on both the account menu and the board switcher.The native controls wear the app's shape now. The colour input on
/admin/tagswas the last control still in the browser's own chrome (a grey bevelled rectangle on a page of soft rounded surfaces); the file picker on/profilehad no styling at all. Both keep the real element and take their shape from the vendor pseudo-elements (::-webkit-color-swatch,::file-selector-button) rather than being replaced — a hand-drawn control is one assistive tech has to be told about twice. Two more of the same kind found alongside: checkboxes and radios had three half-copies of one rule that had drifted apart, and.btn-primary/.btn-danger/.btn-secondarynever settext-decoration: none, so the profile page's "Sign in again" arrived underlined.The admin pages line up.
.admin-page-titlesits outside.admin-page(the sticky header is between them) and never repeated its 880px column, so every admin heading was ~280px left of the panel it heads. On the boards list, the links were a type size larger than the buttons beside them, and a row with a wide access label couldn't shrink its name field so its Delete hung out of line with the rest of the list. On a phone that row's five controls overflowed off the left edge —justify-content: flex-enddoesn't wrap.Explainers say less, and some stopped being paragraphs.
.admin-noteis a mark and one line for the things that report a state rather than describe a control — which is what let the access page's longest paragraph (164 chars, opening with three clauses establishing that nothing was wrong) become one sentence. The calendar's read-only promise moved out of the middle of a paragraph and became a chip beside the link. And the phone menu's three destinations got icons: they were the only rows in that sheet whose word began at its edge, so one list had two left margins.Verified
dotnet buildanddotnet testgreen (381 passing,DocumentationTestsincluded).mobile.spec.js(shadow offsets are all ≤ 0; every label in the sheet shares one left edge),board.spec.js(heading, board chip and panel share a left edge),access.spec.js(the chip, the dot, the row's controls one height and no overflow, and both kinds of note),calendar.spec.js(the read-only chip).dotnet runserver on a fresh database: 73 passed, 3 failed —calendar.spec.js"a six-week month fits…" (reproduces identically on unmodifiedmainhere; it measures a 720px grid and this container's font metrics are 14px taller than the compose image's),calendar.spec.js"the month cascades in once" andi18n.spec.js"a stored choice beats an unsupported browser language" (both failed before I touched anything).access.spec.js's two-member tests andshare.spec.js's origin assertion can't run here at all — no PDS container, and the origin is hard-coded tolocalhost:8090. The full suite still wants the compose stack.Docs updated in the same commit:
ui.md(the fifth thing that follows from the bar, the sheet's one row shape),frontend.md(a new Native form controls section and the note-versus-hint rule),boards-and-permissions.md(the access chip and the two notes),calendar.mdandauth.md. One changelog bullet in both locales.⏱ 77m 36s · 388 turns · tokens: 392.3k in / 116.8k out (+95303.2k cache-read)
📜 Full session transcript
→ Opened PR: #143
→ Filed follow-up issue #144: Counts in the UI read "member(s)" / "card(s)" — four strings, both locales