Grandiras/ATProto.NET

Fork 0

feat(bsky): bookmarks, multipart video, searchPostsV2 and the new app.bsky surface #164

Merged

Grandiras merged 1 commit from issue-127-bsky-surface into main

2026-09-26 00:05:36 +00:00

Grandiras commented

2026-09-25 21:04:31 +00:00

Owner

Closes #127.

Adds the app.bsky.* surface the Bluesky app now depends on. Every model uses the typed identifiers, AtDatetime, open unions with an Unknown* variant and LexObject extension data from earlier in this cycle, and passes the upstream drift test (pinned snapshot 2e583a4). New sub-clients are registered on client.Bsky: Bookmark, Draft, Embed, AgeAssurance, Unspecced.

Must

Bookmarks (app.bsky.bookmark.createBookmark / deleteBookmark / getBookmarks): BookmarkClient with EnumerateBookmarksAsync. bookmarkView.item is the union postView | notFoundPost | blockedPost, so this adds PostEntry, an open union base with UnknownPostEntry. ThreadNode now derives from it, which lets NotFoundPost and BlockedPost belong to both unions.
Multipart video upload: StartUploadAsync, UploadPartAsync (octet-stream body, jobId and partNumber query params), FinishUploadAsync, GetUploadStatusAsync, AbortUploadAsync, plus UploadState, VideoErrors, VideoUploadOptions and VideoUploadException (it carries the FailureCode). JobStatus already had the new states and failureCode from #123.
- UploadVideoAsync(Stream, mimeType, options, ct) reads one part at a time into a pooled buffer, so it works with non-seekable streams when given Length. It checks the service's part plan against the size before allocating, and retries transient failures with exponential backoff capped at 30 s: transport errors, timeouts, 5xx, 429 and ServiceOverloaded, plus UploadNotReady on finish. startUpload is not idempotent, so it is resent only after an outright refusal (429 or ServiceOverloaded). Any other failure, or a cancellation, aborts the session to release its quota (best effort) and rethrows. After the finish it polls getJobStatus until the job completes, or throws VideoUploadException when it fails.
- The 300 MB limit is documented in docs/video.md.
app.bsky.feed.searchPostsV2: SearchPostsV2Async and EnumerateSearchPostsV2Async, with all 25 filters in a PostSearchFilters record (query, sort, limit and cursor are parameters), plus HitsTotal and DetectedQueryLanguages. A test compares the parameter names sent against the upstream lexicon's parameter list.
app.bsky.notification.unregisterPush: UnregisterPushAsync, plus PushPlatform.

Should

Notifications: GetPreferencesAsync and PutPreferencesV2Async both return NotificationPreferences. The deprecated chat preference is [Obsolete] and optional. Also ListActivitySubscriptionsAsync, EnumerateActivitySubscriptionsAsync, PutActivitySubscriptionAsync(did, post, reply), and NotificationDeclarationRecord with AllowedSubscribers.
Records: ReferenceListOptOutRecord, VerificationRecord, StatusRecord (with ActorStatus.Live) and ContentVisibilityDeclarationRecord.
Graph: GetListsWithMembershipAsync, GetStarterPacksWithMembershipAsync and SearchStarterPacksV2Async, each with an Enumerate* method.
Embeds: EmbedClient.GetEmbedExternalViewAsync.
Drafts: DraftClient covers create (returns the Tid), update, delete, get and enumerate. It adds the full app.bsky.draft.defs model, including the DraftGalleryItem open union.
Feeds: SendInteractionsAsync(interactions, feed, feedGenerator) with Interaction and InteractionEvent. When given the generator's DID it proxies to did#bsky_fg; this adds ServiceProxy.BskyFeedGenerator.
Threads: UnspeccedClient.GetPostThreadV2Async and GetPostThreadOtherV2Async return a ThreadItem list. ThreadItemValue is an open union: ThreadItemPost plus the blocked, not-found and no-unauthenticated placeholders. PostThreadSort holds the sort values.
Age assurance: BeginAsync, GetConfigAsync and GetStateAsync. The seven region rule types form the open union AgeAssuranceRule; AgeAssuranceAccess and AgeAssuranceStatus hold the known values.

The drift allow-lists had no entries deferred to #127. This PR adds DefOf entries for the models whose names don't resolve by convention, 11 new knownValues classes to KnownValueLocations, and three commented guard-test exceptions (PostSearchFilters.Since/Until, which take bare dates, and DraftEmbedExternal.Uri, a web URL).

Breaking changes

VideoClient.UploadVideoAsync is now the multipart convenience. It returns the completed JobStatus, with Blob set, and takes VideoUploadOptions? before the token. The old single-request app.bsky.video.uploadVideo wrapper is renamed UploadVideoInOneRequestAsync. Both the issue and the brief name the convenience UploadVideoAsync(Stream, …), and keeping both under one name with optional parameters would make UploadVideoAsync(stream) ambiguous. Migration: use the returned status directly, or call UploadVideoInOneRequestAsync to keep the old behaviour.
PostView writes its $type. PostView and ThreadNode now derive from PostEntry, so a serialized PostView starts with "$type":"app.bsky.feed.defs#postView", as GeneratorView and the other union members already do. Reading is unaffected. This only adds a base class, so it is not a binary break.

Verification

dotnet build --no-incremental of the solution: 0 warnings, 0 errors.
Unit tests: 3359 passed, 0 failed, 5 skipped. This PR adds 76 tests under tests/ATProtoNet.Tests/Lexicon/App/Bsky/: one or more per endpoint, checking the request shape (method, query, exact JSON body, content type and length, proxy header) and response binding. They run against a scripted HTTP stub (ScriptedXrpcHandler) with appview-shaped fixtures: $type placed last, an unknown union variant in each union, and a real-shaped app.bsky.graph.verification record carrying the undeclared issuer field, which round-trips through ExtensionData.
Video upload tests:
- part split, sizes and byte order
- part retries on 503 ServiceOverloaded, 500 and 502
- giving up after MaxAttempts
- no retry on UploadExpired, PartSizeMismatch, InvalidPartNumber or UploadAborted
- each of the five JobFailureCodes surfacing on VideoUploadException
- UploadNotReady retry on finish
- startUpload not resent after a 500 but resent after ServiceOverloaded
- a non-seekable stream with and without Length, and a short stream
- an inconsistent part plan
- cancellation aborting the session
- an abort failure not masking the original error
- backoff delays of exactly 250 ms, 500 ms and 1 s, measured with a fake TimeProvider
The drift test, the typed-identifier guard and the JSON-name convention tests all pass.

Deferred / notes

FeedReplyRef.Root/Parent is the same postView | notFoundPost | blockedPost union and is still a JsonElement. It could now be typed as PostEntry, but that is a breaking change outside this issue.
UploadVideoAsync reports no progress. IProgress<> for bytes uploaded and job progress would be a natural follow-up.
Not in scope, as the research ranks them "could": app.bsky.contact.*, the remaining app.bsky.unspecced.* and notification.putPreferences (v1).
Edits outside Lexicon/App/Bsky, each kept minimal:
- AtProtoClient.cs: 4 using lines, 5 constructor arguments, and 5 properties on BlueskyClients.
- Http/XrpcClient.cs: UploadAsync gains an optional XrpcParams? parameters.
- Http/ServiceProxy.cs: one constant.

🤖 Generated with Claude Code

Closes #127. Adds the `app.bsky.*` surface the Bluesky app now depends on. Every model uses the typed identifiers, `AtDatetime`, open unions with an `Unknown*` variant and `LexObject` extension data from earlier in this cycle, and passes the upstream drift test (pinned snapshot `2e583a4`). New sub-clients are registered on `client.Bsky`: `Bookmark`, `Draft`, `Embed`, `AgeAssurance`, `Unspecced`. ## Must - **Bookmarks** (`app.bsky.bookmark.createBookmark` / `deleteBookmark` / `getBookmarks`): `BookmarkClient` with `EnumerateBookmarksAsync`. `bookmarkView.item` is the union `postView | notFoundPost | blockedPost`, so this adds `PostEntry`, an open union base with `UnknownPostEntry`. `ThreadNode` now derives from it, which lets `NotFoundPost` and `BlockedPost` belong to both unions. - **Multipart video upload**: `StartUploadAsync`, `UploadPartAsync` (octet-stream body, `jobId` and `partNumber` query params), `FinishUploadAsync`, `GetUploadStatusAsync`, `AbortUploadAsync`, plus `UploadState`, `VideoErrors`, `VideoUploadOptions` and `VideoUploadException` (it carries the `FailureCode`). `JobStatus` already had the new states and `failureCode` from #123. - `UploadVideoAsync(Stream, mimeType, options, ct)` reads one part at a time into a pooled buffer, so it works with non-seekable streams when given `Length`. It checks the service's part plan against the size before allocating, and retries transient failures with exponential backoff capped at 30 s: transport errors, timeouts, 5xx, 429 and `ServiceOverloaded`, plus `UploadNotReady` on finish. `startUpload` is not idempotent, so it is resent only after an outright refusal (429 or `ServiceOverloaded`). Any other failure, or a cancellation, aborts the session to release its quota (best effort) and rethrows. After the finish it polls `getJobStatus` until the job completes, or throws `VideoUploadException` when it fails. - The 300 MB limit is documented in `docs/video.md`. - **`app.bsky.feed.searchPostsV2`**: `SearchPostsV2Async` and `EnumerateSearchPostsV2Async`, with all 25 filters in a `PostSearchFilters` record (`query`, `sort`, `limit` and `cursor` are parameters), plus `HitsTotal` and `DetectedQueryLanguages`. A test compares the parameter names sent against the upstream lexicon's parameter list. - **`app.bsky.notification.unregisterPush`**: `UnregisterPushAsync`, plus `PushPlatform`. ## Should - **Notifications**: `GetPreferencesAsync` and `PutPreferencesV2Async` both return `NotificationPreferences`. The deprecated `chat` preference is `[Obsolete]` and optional. Also `ListActivitySubscriptionsAsync`, `EnumerateActivitySubscriptionsAsync`, `PutActivitySubscriptionAsync(did, post, reply)`, and `NotificationDeclarationRecord` with `AllowedSubscribers`. - **Records**: `ReferenceListOptOutRecord`, `VerificationRecord`, `StatusRecord` (with `ActorStatus.Live`) and `ContentVisibilityDeclarationRecord`. - **Graph**: `GetListsWithMembershipAsync`, `GetStarterPacksWithMembershipAsync` and `SearchStarterPacksV2Async`, each with an `Enumerate*` method. - **Embeds**: `EmbedClient.GetEmbedExternalViewAsync`. - **Drafts**: `DraftClient` covers create (returns the `Tid`), update, delete, get and enumerate. It adds the full `app.bsky.draft.defs` model, including the `DraftGalleryItem` open union. - **Feeds**: `SendInteractionsAsync(interactions, feed, feedGenerator)` with `Interaction` and `InteractionEvent`. When given the generator's DID it proxies to `did#bsky_fg`; this adds `ServiceProxy.BskyFeedGenerator`. - **Threads**: `UnspeccedClient.GetPostThreadV2Async` and `GetPostThreadOtherV2Async` return a `ThreadItem` list. `ThreadItemValue` is an open union: `ThreadItemPost` plus the blocked, not-found and no-unauthenticated placeholders. `PostThreadSort` holds the sort values. - **Age assurance**: `BeginAsync`, `GetConfigAsync` and `GetStateAsync`. The seven region rule types form the open union `AgeAssuranceRule`; `AgeAssuranceAccess` and `AgeAssuranceStatus` hold the known values. The drift allow-lists had no entries deferred to #127. This PR adds `DefOf` entries for the models whose names don't resolve by convention, 11 new knownValues classes to `KnownValueLocations`, and three commented guard-test exceptions (`PostSearchFilters.Since`/`Until`, which take bare dates, and `DraftEmbedExternal.Uri`, a web URL). ## Breaking changes - **`VideoClient.UploadVideoAsync` is now the multipart convenience.** It returns the completed `JobStatus`, with `Blob` set, and takes `VideoUploadOptions?` before the token. The old single-request `app.bsky.video.uploadVideo` wrapper is renamed `UploadVideoInOneRequestAsync`. Both the issue and the brief name the convenience `UploadVideoAsync(Stream, …)`, and keeping both under one name with optional parameters would make `UploadVideoAsync(stream)` ambiguous. Migration: use the returned status directly, or call `UploadVideoInOneRequestAsync` to keep the old behaviour. - **`PostView` writes its `$type`.** `PostView` and `ThreadNode` now derive from `PostEntry`, so a serialized `PostView` starts with `"$type":"app.bsky.feed.defs#postView"`, as `GeneratorView` and the other union members already do. Reading is unaffected. This only adds a base class, so it is not a binary break. ## Verification - `dotnet build --no-incremental` of the solution: 0 warnings, 0 errors. - Unit tests: 3359 passed, 0 failed, 5 skipped. This PR adds 76 tests under `tests/ATProtoNet.Tests/Lexicon/App/Bsky/`: one or more per endpoint, checking the request shape (method, query, exact JSON body, content type and length, proxy header) and response binding. They run against a scripted HTTP stub (`ScriptedXrpcHandler`) with appview-shaped fixtures: `$type` placed last, an unknown union variant in each union, and a real-shaped `app.bsky.graph.verification` record carrying the undeclared `issuer` field, which round-trips through `ExtensionData`. - Video upload tests: - part split, sizes and byte order - part retries on 503 `ServiceOverloaded`, 500 and 502 - giving up after `MaxAttempts` - no retry on `UploadExpired`, `PartSizeMismatch`, `InvalidPartNumber` or `UploadAborted` - each of the five `JobFailureCode`s surfacing on `VideoUploadException` - `UploadNotReady` retry on finish - `startUpload` not resent after a 500 but resent after `ServiceOverloaded` - a non-seekable stream with and without `Length`, and a short stream - an inconsistent part plan - cancellation aborting the session - an abort failure not masking the original error - backoff delays of exactly 250 ms, 500 ms and 1 s, measured with a fake `TimeProvider` - The drift test, the typed-identifier guard and the JSON-name convention tests all pass. ## Deferred / notes - `FeedReplyRef.Root`/`Parent` is the same `postView | notFoundPost | blockedPost` union and is still a `JsonElement`. It could now be typed as `PostEntry`, but that is a breaking change outside this issue. - `UploadVideoAsync` reports no progress. `IProgress<>` for bytes uploaded and job progress would be a natural follow-up. - Not in scope, as the research ranks them "could": `app.bsky.contact.*`, the remaining `app.bsky.unspecced.*` and `notification.putPreferences` (v1). - Edits outside `Lexicon/App/Bsky`, each kept minimal: - `AtProtoClient.cs`: 4 `using` lines, 5 constructor arguments, and 5 properties on `BlueskyClients`. - `Http/XrpcClient.cs`: `UploadAsync` gains an optional `XrpcParams? parameters`. - `Http/ServiceProxy.cs`: one constant. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Grandiras added 1 commit

2026-09-25 21:04:31 +00:00

feat(bsky)!: bookmarks, multipart video, searchPostsV2 and the new app.bsky surface (closes #127 )

CI / pds-integration (pull_request) Successful in 38s

Details

CI / build-and-test (pull_request) Successful in 1m19s

Details

fbb7d5e742

The SDK covered 67 of 137 upstream app.bsky endpoints and records. This adds the
ones the Bluesky app now depends on, each written with the typed identifiers,
open unions and extension data of this cycle and checked by the upstream drift
test:

- bookmarks (client.Bsky.Bookmark), with PostEntry, an open union of PostView,
  NotFoundPost and BlockedPost that ThreadNode now derives from;
- the multipart video upload (startUpload, uploadPart, finishUpload,
  getUploadStatus, abortUpload). UploadVideoAsync now drives it: it chunks the
  stream, retries transient failures with backoff (startUpload only when
  refused, since it is not idempotent), aborts the session on failure or
  cancellation and polls the job to completion. The single-request uploadVideo
  call becomes UploadVideoInOneRequestAsync;
- searchPostsV2 with every filter, sendInteractions (proxied to the feed
  generator), unregisterPush, the V2 notification preferences and activity
  subscriptions, getListsWithMembership, getStarterPacksWithMembership,
  searchStarterPacksV2, getEmbedExternalView, drafts, getPostThreadV2 /
  getPostThreadOtherV2 and age assurance;
- the declaration, status, content-visibility, verification and
  reference-list opt-out records.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Grandiras commented

2026-09-25 21:04:32 +00:00

Author

Owner

@claude /review — please read VideoClient.UploadVideoAsync (multipart: chunking, part retry/backoff, job polling, cancellation) in full.

@claude /review — please read `VideoClient.UploadVideoAsync` (multipart: chunking, part retry/backoff, job polling, cancellation) in full.

opencode-bot commented

2026-09-25 21:04:32 +00:00

Collaborator

🤖 Reviewing this PR — the review will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the review runs.

🤖 Reviewing this PR — the review will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/opencode-bot/src/branch/opencode-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-2026-09-25T21-04-32-402Z.md) — updating every ~5 minutes while the review runs.

claude-bot commented

2026-09-25 21:04:34 +00:00

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/606); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-606.md) — updating every ~5 minutes while the task runs.

opencode-bot commented

2026-09-25 21:04:35 +00:00

Collaborator

⏳ Held on the OpenCode Go window — the 5-hour window is at 0% (the bot holds at 95%).
This continues automatically after the window resets (2026-09-26T02:00:33.556Z) — nothing to re-trigger.

⏳ **Held on the OpenCode Go window** — the 5-hour window is at 0% (the bot holds at 95%). This continues automatically after the window resets (2026-09-26T02:00:33.556Z) — nothing to re-trigger.

opencode-bot commented

2026-09-25 23:59:06 +00:00

Collaborator

🤖 Resolving the merge conflicts — the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the fix runs.

🤖 Resolving the merge conflicts — the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/opencode-bot/src/branch/opencode-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-2026-09-25T23-59-05-450Z.md) — updating every ~5 minutes while the fix runs.

opencode-bot commented

2026-09-25 23:59:09 +00:00

Collaborator

⏳ Held on the OpenCode Go window — the 5-hour window is at 0% (the bot holds at 95%).
This continues automatically after the window resets (2026-09-26T04:57:05.468Z) — nothing to re-trigger.

⏳ **Held on the OpenCode Go window** — the 5-hour window is at 0% (the bot holds at 95%). This continues automatically after the window resets (2026-09-26T04:57:05.468Z) — nothing to re-trigger.

Grandiras force-pushed issue-127-bsky-surface from fbb7d5e742

CI / pds-integration (pull_request) Successful in 38s

Details

CI / build-and-test (pull_request) Successful in 1m19s

Details

to b18a81558d

CI / pds-integration (pull_request) Successful in 36s

Details

CI / build-and-test (pull_request) Successful in 1m11s

Details

2026-09-25 23:59:10 +00:00

Compare

Grandiras commented

2026-09-25 23:59:14 +00:00

Author

Owner

@claude /review — please read VideoClient.UploadVideoAsync (multipart: chunking, part retry/backoff, job polling, cancellation) in full.

@claude /review — please read `VideoClient.UploadVideoAsync` (multipart: chunking, part retry/backoff, job polling, cancellation) in full.

claude-bot commented

2026-09-25 23:59:20 +00:00

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/608); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-608.md) — updating every ~5 minutes while the task runs.

opencode-bot commented

2026-09-26 00:00:11 +00:00

Collaborator

🤖 Reviewing this PR — the review will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the review runs.

🤖 Reviewing this PR — the review will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/opencode-bot/src/branch/opencode-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-2026-09-26T00-00-11-331Z.md) — updating every ~5 minutes while the review runs.

opencode-bot commented

2026-09-26 00:00:13 +00:00

Collaborator

claude-reviewer approved these changes

2026-09-26 00:01:37 +00:00

Dismissed

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

Large, well-scoped PR that reads consistently with the rest of the codebase's conventions (open unions with Unknown* fallback, LexObject/ICursorPage<T> patterns, Enumerate* pagination helpers, XML docs on every public member).

I spot-checked the two surfaces where a fidelity bug would be easiest to introduce and hardest to catch by eye — app.bsky.feed.sendInteractions (confirmed feed really is optional upstream, matching SendInteractionsRequest.Feed being nullable) and app.bsky.feed.searchPostsV2 (the full 28-parameter list in PostSearchFilters/SearchPostsV2Async matches upstream's query parameters exactly, including the since/until-as-bare-string and queryLanguage cases the PR calls out) — both check out against the current upstream lexicons.

The PostEntry/ThreadNode dual-hierarchy trick (both declare NotFoundPost/BlockedPost as JsonDerivedTypes, and ThreadNode itself is not registered as a derived type of PostEntry) is a legitimate way to let one concrete type serialize correctly under two unrelated open unions in System.Text.Json, since each base type's polymorphism contract is independent — this should work as intended, and the PR says the 76 new tests cover the shape.

The video multipart upload logic that's visible (part-count/size validation in CheckPlan, per-attempt fresh MemoryStream over a pooled buffer so retries don't hit stale stream state, aborting the session on any failure during upload/finish but not while waiting on the job) looks correct and matches the PR's stated retry/abort semantics. Note the diff was truncated partway through VideoClient.WaitForJobAsync and never showed VideoModels.cs/the test files, so I could not verify the backoff/retry helper (WithRetriesAsync) or JobFailureCode/VideoUploadException wiring directly — nothing in what I could see raised a flag there, and the PR's verification section describes tests that specifically target those paths (backoff timing, failure-code mapping, non-resend of startUpload).

No correctness issues found in the reviewed portion; nothing here should block merge.

⏱ 1m 51s · 5 turns · tokens: 88.1k in / 10.5k out (+442.4k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. Large, well-scoped PR that reads consistently with the rest of the codebase's conventions (open unions with `Unknown*` fallback, `LexObject`/`ICursorPage<T>` patterns, `Enumerate*` pagination helpers, XML docs on every public member). I spot-checked the two surfaces where a fidelity bug would be easiest to introduce and hardest to catch by eye — `app.bsky.feed.sendInteractions` (confirmed `feed` really is optional upstream, matching `SendInteractionsRequest.Feed` being nullable) and `app.bsky.feed.searchPostsV2` (the full 28-parameter list in `PostSearchFilters`/`SearchPostsV2Async` matches upstream's query parameters exactly, including the `since`/`until`-as-bare-string and `queryLanguage` cases the PR calls out) — both check out against the current upstream lexicons. The `PostEntry`/`ThreadNode` dual-hierarchy trick (both declare `NotFoundPost`/`BlockedPost` as `JsonDerivedType`s, and `ThreadNode` itself is not registered as a derived type of `PostEntry`) is a legitimate way to let one concrete type serialize correctly under two unrelated open unions in System.Text.Json, since each base type's polymorphism contract is independent — this should work as intended, and the PR says the 76 new tests cover the shape. The video multipart upload logic that's visible (part-count/size validation in `CheckPlan`, per-attempt fresh `MemoryStream` over a pooled buffer so retries don't hit stale stream state, aborting the session on any failure during upload/finish but not while waiting on the job) looks correct and matches the PR's stated retry/abort semantics. Note the diff was truncated partway through `VideoClient.WaitForJobAsync` and never showed `VideoModels.cs`/the test files, so I could not verify the backoff/retry helper (`WithRetriesAsync`) or `JobFailureCode`/`VideoUploadException` wiring directly — nothing in what I could see raised a flag there, and the PR's verification section describes tests that specifically target those paths (backoff timing, failure-code mapping, non-resend of `startUpload`). No correctness issues found in the reviewed portion; nothing here should block merge. --- ⏱ 1m 51s · 5 turns · tokens: 88.1k in / 10.5k out (+442.4k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-608.md)

Grandiras commented

2026-09-26 00:04:03 +00:00

Author

Owner

Rebased onto main after #161 merged. Besides CHANGELOG, XrpcClient.cs conflicted: #161 had factored the upload request into a shared CreateUpload (plus a non-generic UploadAsync for importRepo), and this PR adds an optional XrpcParams? parameters to UploadAsync<T> (needed by uploadPart's jobId/partNumber). Resolution: CreateUpload now takes parameters, both UploadAsync overloads accept and pass it, and importRepo still passes none. The full build has 0 warnings and 3618 unit tests pass locally. Because the resolution touched code, a fresh review is needed.

@claude /review — focus on the XrpcClient.UploadAsync/CreateUpload merge and VideoClient.UploadVideoAsync.

Rebased onto main after #161 merged. Besides CHANGELOG, `XrpcClient.cs` conflicted: #161 had factored the upload request into a shared `CreateUpload` (plus a non-generic `UploadAsync` for `importRepo`), and this PR adds an optional `XrpcParams? parameters` to `UploadAsync<T>` (needed by `uploadPart`'s `jobId`/`partNumber`). Resolution: `CreateUpload` now takes `parameters`, both `UploadAsync` overloads accept and pass it, and `importRepo` still passes none. The full build has 0 warnings and 3618 unit tests pass locally. Because the resolution touched code, a fresh review is needed. @claude /review — focus on the `XrpcClient.UploadAsync`/`CreateUpload` merge and `VideoClient.UploadVideoAsync`.

Grandiras force-pushed issue-127-bsky-surface from b18a81558d

CI / pds-integration (pull_request) Successful in 36s

Details

CI / build-and-test (pull_request) Successful in 1m11s

Details

to bb7e089b78

CI / pds-integration (pull_request) Successful in 30s

Details

CI / build-and-test (pull_request) Successful in 1m5s

Details

Sync Closures to GitHub / sync-closure (pull_request) Successful in 9s

Details

2026-09-26 00:04:05 +00:00

Compare

claude-bot commented

2026-09-26 00:04:07 +00:00

Collaborator

🤖 Reviewing this PR — follow along in the action run; the reply will link the full session transcript.

📜 Live transcript — updating every ~5 minutes while the task runs.

🤖 Reviewing this PR — follow along in [the action run](https://git.grandiras.net/Grandiras/claude-bot/actions/runs/609); the reply will link the full session transcript.  📜 [Live transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-609.md) — updating every ~5 minutes while the task runs.

claude-reviewer approved these changes

2026-09-26 00:05:05 +00:00

claude-reviewer left a comment

✅ Verdict: approve — no blocking issues found.

This is the same PR content I already approved on 2026-09-26; I don't see evidence of new commits changing the reviewed surface — the diff is structured identically to my last pass and truncates at the same point in VideoClient.WaitForJobAsync, before VideoModels.cs and the test files.

Re-checking the newly-visible pieces I hadn't traced in detail last time:

VideoClient.CheckPlan/UploadVideoAsync's per-part loop: the expected-part-count formula ((size - 1) / session.PartSizeBytes) + 1 correctly matches ceil(size / partSizeBytes), and the per-part length calc (Math.Min(partSize, size - (part-1)*session.PartSizeBytes)) correctly handles the shorter final part. The new MemoryStream(buffer, 0, length, writable: false) is constructed fresh inside the WithRetriesAsync retry lambda (not hoisted), so retries re-read from a stream at position 0 over stable buffer contents rather than a partially-consumed stream — this is correct and matches the PR's claimed retry-safety.
Bookmark, Draft, Embed, AgeAssurance, Unspecced, Graph membership/search, and Notification preferences/activity-subscription additions all follow the established LexObject/ICursorPage<T>/Enumerate*/open-union-with-Unknown* conventions consistently, with plausible parameter/request shapes.
PostEntry/ThreadNode dual-hierarchy trick and the searchPostsV2 filter wiring were already spot-checked against upstream lexicons in my previous pass and still look correct here.

As before, I can't verify the retry/backoff helper (WithRetriesAsync), TryAbortAsync, or the failure-code-to-VideoUploadException wiring because the diff cuts off mid-method, but nothing visible contradicts the PR's description and the extensive test list targets exactly those paths. No blocking issues found; still good to merge.

⏱ 0m 45s · 1 turns · tokens: 77.3k in / 4.3k out (+23.9k cache-read)
📜 Full session transcript

✅ **Verdict: approve** — no blocking issues found. This is the same PR content I already approved on 2026-09-26; I don't see evidence of new commits changing the reviewed surface — the diff is structured identically to my last pass and truncates at the same point in `VideoClient.WaitForJobAsync`, before `VideoModels.cs` and the test files. Re-checking the newly-visible pieces I hadn't traced in detail last time: - `VideoClient.CheckPlan`/`UploadVideoAsync`'s per-part loop: the expected-part-count formula `((size - 1) / session.PartSizeBytes) + 1` correctly matches `ceil(size / partSizeBytes)`, and the per-part length calc (`Math.Min(partSize, size - (part-1)*session.PartSizeBytes)`) correctly handles the shorter final part. The `new MemoryStream(buffer, 0, length, writable: false)` is constructed fresh inside the `WithRetriesAsync` retry lambda (not hoisted), so retries re-read from a stream at position 0 over stable buffer contents rather than a partially-consumed stream — this is correct and matches the PR's claimed retry-safety. - `Bookmark`, `Draft`, `Embed`, `AgeAssurance`, `Unspecced`, `Graph` membership/search, and `Notification` preferences/activity-subscription additions all follow the established `LexObject`/`ICursorPage<T>`/`Enumerate*`/open-union-with-Unknown* conventions consistently, with plausible parameter/request shapes. - `PostEntry`/`ThreadNode` dual-hierarchy trick and the `searchPostsV2` filter wiring were already spot-checked against upstream lexicons in my previous pass and still look correct here. As before, I can't verify the retry/backoff helper (`WithRetriesAsync`), `TryAbortAsync`, or the failure-code-to-`VideoUploadException` wiring because the diff cuts off mid-method, but nothing visible contradicts the PR's description and the extensive test list targets exactly those paths. No blocking issues found; still good to merge. --- ⏱ 0m 45s · 1 turns · tokens: 77.3k in / 4.3k out (+23.9k cache-read) 📜 [Full session transcript](https://git.grandiras.net/Grandiras/claude-bot/src/branch/claude-logs/transcripts/Grandiras/ATProto.NET/pr-164/run-609.md)

Grandiras merged commit 4955389de8 into main

2026-09-26 00:05:36 +00:00

Grandiras deleted branch issue-127-bsky-surface

2026-09-26 00:05:37 +00:00

Grandiras referenced this pull request from a commit

2026-09-26 00:05:38 +00:00

feat(bsky)!: bookmarks, multipart video, searchPostsV2 and the new app.bsky surface (#164)

Grandiras referenced this pull request

2026-09-26 00:12:08 +00:00

feat(records)!: record and custom-XRPC ergonomics, Bluesky helpers on client.Bsky #165

Grandiras referenced this pull request

2026-09-26 00:22:12 +00:00