test: consolidate test infrastructure and remove low-value tests #137

New issue

Closed

opened 2026-09-24 12:39:10 +00:00 by Grandiras · 1 comment

Grandiras commented

2026-09-24 12:39:10 +00:00

Owner

Part of the v0.7.0 update cycle (wave 8). Test infrastructure consolidation and low-value test removal. Do this after the feature work so it doesn't conflict with every PR.

One shared scripted HttpMessageHandler stub and an XrpcTestClient fixture replace the 27 hand-rolled handlers.
One XrpcTestHost replaces the 4 TestServer hosts.
Token-store and space-store contract base classes run against every implementation.
Move EF tests to Sqlite and drop Microsoft.EntityFrameworkCore.InMemory, which also removes the version-pin trap.
One enum-driven [RequiresFact(...)] for the env-gated integration tests (RequiresPdsFact/RequiresBlueskyFact currently ignore ATPROTO_REQUIRE_INTEGRATION).
Unit tests must not touch the network: SecurityTests opens real TCP connections and AtProtoClientApplyOAuthTests does real DNS.
Remove tests that test nothing: DTO getter tests (now covered by the convention and drift tests), constant-equals-literal tests, smoke tests, and self-consistency tests subsumed by pinned vectors. Merge duplicate facts into theories.
Integration CI: AuthenticatedClientFixture provisions its own account (like SpaceNetworkFixture), and the CI filter widens beyond PdsAdminTests, so login/refresh/record CRUD run against the reference PDS on every PR.
Coverage for core paths that have no unit tests today: LoginAsync/ResumeSessionAsync/LogoutAsync, RecordCollection CRUD, and the custom-XRPC entry points.

Part of the v0.7.0 update cycle (wave 8). Test infrastructure consolidation and low-value test removal. Do this after the feature work so it doesn't conflict with every PR. - [ ] One shared scripted `HttpMessageHandler` stub and an `XrpcTestClient` fixture replace the 27 hand-rolled handlers. - [ ] One `XrpcTestHost` replaces the 4 TestServer hosts. - [ ] Token-store and space-store **contract** base classes run against every implementation. - [ ] Move EF tests to Sqlite and drop `Microsoft.EntityFrameworkCore.InMemory`, which also removes the version-pin trap. - [ ] One enum-driven `[RequiresFact(...)]` for the env-gated integration tests (`RequiresPdsFact`/`RequiresBlueskyFact` currently ignore `ATPROTO_REQUIRE_INTEGRATION`). - [ ] Unit tests must not touch the network: `SecurityTests` opens real TCP connections and `AtProtoClientApplyOAuthTests` does real DNS. - [ ] Remove tests that test nothing: DTO getter tests (now covered by the convention and drift tests), constant-equals-literal tests, smoke tests, and self-consistency tests subsumed by pinned vectors. Merge duplicate facts into theories. - [ ] Integration CI: `AuthenticatedClientFixture` provisions its own account (like `SpaceNetworkFixture`), and the CI filter widens beyond `PdsAdminTests`, so login/refresh/record CRUD run against the reference PDS on every PR. - [ ] Coverage for core paths that have no unit tests today: `LoginAsync`/`ResumeSessionAsync`/`LogoutAsync`, `RecordCollection` CRUD, and the custom-XRPC entry points.

Grandiras referenced this issue

2026-09-24 12:39:33 +00:00

Tracking: v0.7.0 update cycle — protocol catch-up, optimization, debloat, API reshaping #141

Grandiras referenced this issue

2026-09-25 21:00:33 +00:00

Tracking: v0.7.0 update cycle — protocol catch-up, optimization, debloat, API reshaping #141

Grandiras commented

2026-09-26 20:57:31 +00:00

Author

Owner

Splitting this into two PRs, so most of it can run in parallel with the second half of #136:

Now, branch issue-137-tests: the shared scripted HttpMessageHandler stub and XrpcTestClient, one XrpcTestHost, the enum-driven [RequiresFact(...)], network-free unit tests, removing low-value tests, and the core coverage gaps. All of it stays out of the EF-store and DI-registration tests that #136 is moving.
After #136 merges: token-store and space-store contract base classes, EF tests on SQLite with Microsoft.EntityFrameworkCore.InMemory dropped, and the integration-CI changes.
The issue closes with the second PR.

Splitting this into two PRs, so most of it can run in parallel with the second half of #136: 1. **Now**, branch `issue-137-tests`: the shared scripted `HttpMessageHandler` stub and `XrpcTestClient`, one `XrpcTestHost`, the enum-driven `[RequiresFact(...)]`, network-free unit tests, removing low-value tests, and the core coverage gaps. All of it stays out of the EF-store and DI-registration tests that #136 is moving. 2. **After #136 merges:** token-store and space-store contract base classes, EF tests on SQLite with `Microsoft.EntityFrameworkCore.InMemory` dropped, and the integration-CI changes. The issue closes with the second PR.

Grandiras referenced this issue from a commit

2026-09-26 22:11:39 +00:00

test: migrate WireFidelityTests to HttpStub (#137)

Grandiras referenced this issue from a commit

2026-09-26 22:11:39 +00:00

test: migrate TypedBskyClientTests to HttpStub, add HttpStub.ClearRequests (#137)

Grandiras referenced this issue from a commit

2026-09-26 22:11:39 +00:00

test: migrate LabelerClientTests and ComAtProtoGapTests to HttpStub (#137)

Grandiras referenced this issue from a commit

2026-09-26 22:11:39 +00:00

test: migrate IdentityClientTests and StandardSiteClientTests to HttpStub (#137)