refactor(hosting): shared base for the PDS container resources #116

New issue

Closed

opened 2026-09-24 12:28:56 +00:00 by Grandiras · 0 comments

Grandiras commented

2026-09-24 12:28:56 +00:00

Owner

Part of the v0.7.0 update cycle. Removes duplication in ATProtoNet.Aspire.Hosting and keeps every feature.

Scope

Introduce a shared abstract base for AtProtoPdsContainerResource and AtProtoTranquilPdsContainerResource: HttpEndpointName, HealthCheckPath, Hostname, JwtSecretParameter, ConnectionStringExpression.
Replace the duplicated method pairs with generic With* extensions on the base: WithHostname ×2, WithJwtSecret, the bind-mount/volume setters, the clear-mounts helper, and project wiring (WithAtProtoPds / WithAtProtoTranquilPds share one implementation). Callers stay source-compatible; the binary break is acceptable.
Keep the 18 environment-variable convenience methods (WithPlcUrl, WithCrawlers, …) and Tranquil support. This is a consolidation, not a feature removal.
Tests: turn the parallel Pds/Tranquil test pairs into theories over the flavour where they test shared behaviour. Share GetEnvironmentAsync / PublishModeBuilder helpers. The Aspire manifest test in CI must keep passing.

Acceptance

Behaviour is identical: the same environment, mounts, endpoints and manifest output for both flavours.
CHANGELOG: Changed, plus a Breaking changes line if binary signatures move to the base type.

Part of the v0.7.0 update cycle. Removes duplication in `ATProtoNet.Aspire.Hosting` and keeps every feature. ## Scope - [ ] Introduce a shared abstract base for `AtProtoPdsContainerResource` and `AtProtoTranquilPdsContainerResource`: `HttpEndpointName`, `HealthCheckPath`, `Hostname`, `JwtSecretParameter`, `ConnectionStringExpression`. - [ ] Replace the duplicated method pairs with generic `With*` extensions on the base: `WithHostname` ×2, `WithJwtSecret`, the bind-mount/volume setters, the clear-mounts helper, and project wiring (`WithAtProtoPds` / `WithAtProtoTranquilPds` share one implementation). Callers stay source-compatible; the binary break is acceptable. - [ ] **Keep** the 18 environment-variable convenience methods (`WithPlcUrl`, `WithCrawlers`, …) and Tranquil support. This is a consolidation, not a feature removal. - [ ] Tests: turn the parallel Pds/Tranquil test pairs into theories over the flavour where they test shared behaviour. Share `GetEnvironmentAsync` / `PublishModeBuilder` helpers. The Aspire manifest test in CI must keep passing. ## Acceptance - Behaviour is identical: the same environment, mounts, endpoints and manifest output for both flavours. - CHANGELOG: `Changed`, plus a `Breaking changes` line if binary signatures move to the base type.

Grandiras referenced this issue

2026-09-24 12:39:33 +00:00

Tracking: v0.7.0 update cycle — protocol catch-up, optimization, debloat, API reshaping #141

Grandiras referenced this issue from a commit

2026-09-24 12:50:21 +00:00

refactor(hosting): shared base for the PDS container resources (closes #116)

Grandiras referenced this issue from a pull request that will close it,

2026-09-24 12:50:23 +00:00

refactor(hosting): shared base for the PDS container resources #143