Grandiras/ATProto.NET
1
1
Fork 0
Code Issues Pull requests Projects Releases 9 Packages 8 Wiki Activity Actions

chore: consolidate project metadata, drop unused dependencies and vendored sample assets #110

New issue
Closed
opened 2026-09-24 12:28:54 +00:00 by Grandiras · 0 comments
Grandiras commented 2026-09-24 12:28:54 +00:00
Owner
Copy link

Part of the v0.7.0 update cycle. This is cleanup the v0.6.0 sweep missed, with no intended behaviour change.

Scope

Project files

  • Move package metadata that every project duplicates into Directory.Build.props: Authors, PackageLicenseExpression, PackageProjectUrl, RepositoryUrl, RepositoryType, PackageReadmeFile, TargetFramework, Nullable, ImplicitUsings. Optionally add src/, tests/ and samples/ Directory.Build.props files. Description, PackageTags and PackageId stay per project wherever they differ.
  • Drop settings that equal their defaults: LangVersion latest, TreatWarningsAsErrors false, and RootNamespace/AssemblyName wherever they equal the project name.
  • Keep GenerateDocumentationFile and CS1591 as an error on every packable src/ project, set once.
  • Remove Microsoft.Extensions.Http and Microsoft.Extensions.Options from src/ATProtoNet/ATProtoNet.csproj; the core uses neither. This shrinks the core dependency closure from 14 packages to 3. Do not touch ATProtoNet.Server's package references; that belongs to the package-restructure issue.
  • Remove redundant transitive ProjectReferences from the samples and from ATProtoNet.IntegrationTests.
  • atproto-lexgen --version should report the assembly's informational version, not the hard-coded "1.0.0".
  • .gitignore: remove the duplicate .idea/ line and add nupkg/.

Dead code

  • Remove unnecessary usings (IDE0005) across src/, tests/, tools/ and samples/. Skip files under Identity/, Crypto/, Repo/, Spaces/, Serialization/, Lexicon/**/*Models.cs, ATProtoNet.Server/Spaces/ and ATProtoNet.Aspire.Hosting/; parallel PRs are rewriting those.
  • Remove unused internals: XrpcClient.RefreshToken, StandardSiteClient._xrpc, and unused private or internal parameters (OAuthClient currentNonce, LexiconGenerator EmitPlan/LexiconEmitter).

Samples

  • Remove the vendored Bootstrap trees (88 tracked files, 17.4 MB). Only bootstrap.min.css is referenced, so keep just that file or load it from a CDN with SRI.
  • Fold samples/BlazorOAuthSample into samples/ServerIntegrationSample, which is a strict superset. Update ATProto.NET.slnx and the doc links (docs/blazor.md, docs/oauth.md, docs/architecture.md).
  • Remove unused Blazor template leftovers from the remaining sample.
  • Link SpacesSample from docs/spaces.md.

Acceptance

  • dotnet build passes with 0 warnings and all unit tests pass.
  • For each packable project, the .nuspec metadata (authors, license, URLs, readme, dependencies other than the two removed ones) is unchanged. Compare dotnet pack output before and after.
Part of the v0.7.0 update cycle. This is cleanup the v0.6.0 sweep missed, with **no intended behaviour change**. ## Scope **Project files** - [ ] Move package metadata that every project duplicates into `Directory.Build.props`: `Authors`, `PackageLicenseExpression`, `PackageProjectUrl`, `RepositoryUrl`, `RepositoryType`, `PackageReadmeFile`, `TargetFramework`, `Nullable`, `ImplicitUsings`. Optionally add `src/`, `tests/` and `samples/` `Directory.Build.props` files. `Description`, `PackageTags` and `PackageId` stay per project wherever they differ. - [ ] Drop settings that equal their defaults: `LangVersion latest`, `TreatWarningsAsErrors false`, and `RootNamespace`/`AssemblyName` wherever they equal the project name. - [ ] Keep `GenerateDocumentationFile` and `CS1591` as an error on every packable `src/` project, set once. - [ ] Remove `Microsoft.Extensions.Http` and `Microsoft.Extensions.Options` from `src/ATProtoNet/ATProtoNet.csproj`; the core uses neither. This shrinks the core dependency closure from 14 packages to 3. **Do not** touch `ATProtoNet.Server`'s package references; that belongs to the package-restructure issue. - [ ] Remove redundant transitive `ProjectReference`s from the samples and from `ATProtoNet.IntegrationTests`. - [ ] `atproto-lexgen --version` should report the assembly's informational version, not the hard-coded `"1.0.0"`. - [ ] `.gitignore`: remove the duplicate `.idea/` line and add `nupkg/`. **Dead code** - [ ] Remove unnecessary `using`s (IDE0005) across `src/`, `tests/`, `tools/` and `samples/`. **Skip** files under `Identity/`, `Crypto/`, `Repo/`, `Spaces/`, `Serialization/`, `Lexicon/**/*Models.cs`, `ATProtoNet.Server/Spaces/` and `ATProtoNet.Aspire.Hosting/`; parallel PRs are rewriting those. - [ ] Remove unused internals: `XrpcClient.RefreshToken`, `StandardSiteClient._xrpc`, and unused private or internal parameters (`OAuthClient` `currentNonce`, LexiconGenerator `EmitPlan`/`LexiconEmitter`). **Samples** - [ ] Remove the vendored Bootstrap trees (88 tracked files, 17.4 MB). Only `bootstrap.min.css` is referenced, so keep just that file or load it from a CDN with SRI. - [ ] Fold `samples/BlazorOAuthSample` into `samples/ServerIntegrationSample`, which is a strict superset. Update `ATProto.NET.slnx` and the doc links (`docs/blazor.md`, `docs/oauth.md`, `docs/architecture.md`). - [ ] Remove unused Blazor template leftovers from the remaining sample. - [ ] Link `SpacesSample` from `docs/spaces.md`. ## Acceptance - `dotnet build` passes with 0 warnings and all unit tests pass. - For each packable project, the `.nuspec` metadata (authors, license, URLs, readme, dependencies other than the two removed ones) is unchanged. Compare `dotnet pack` output before and after.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.8.0
v0.7.0
v0.6.0
v0.5.0
v0.4.0
v0.3.0
v0.2.0
v0.1.1
v0.1.0
Labels
Clear labels   
breaking-change
Introduces a breaking API change

  
bug
Something is not working correctly

  
documentation
Documentation improvements

  
duplicate
This issue or PR already exists

  
enhancement
New feature or improvement

  
good first issue
Good for newcomers to the project

  
help wanted
Extra attention is needed

  
performance
Performance-related issue or improvement

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
breaking-change
bug
documentation
duplicate
enhancement
good first issue
help wanted
performance
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Grandiras/ATProto.NET#110
No description provided.